feat: Add reusable API rate limiting helpers#1237
Open
msgem0523 wants to merge 1 commit into
Open
Conversation
Contributor
|
@msgem0523 is attempting to deploy a commit to the vetswhocode-web-app Team on Vercel. A member of the Team first needs to authorize it. |
jeromehardaway
requested changes
Jul 1, 2026
jeromehardaway
left a comment
jeromehardaway
left a comment
Contributor
There was a problem hiding this comment.
Review the work to expand the rate limit requests if needed. Also lets verify if chat needs this since its only used with you all and J0D!3 handles that.
Comment on lines
+74
to
+79
| export const RATE_LIMITS = { | ||
| default: { maxRequests: 20, windowMs: 15 * 60 * 1000 }, | ||
| strict: { maxRequests: 10, windowMs: 15 * 60 * 1000 }, | ||
| ai: { maxRequests: 5, windowMs: 15 * 60 * 1000 }, | ||
| search: { maxRequests: 30, windowMs: 15 * 60 * 1000 }, | ||
| public: { maxRequests: 50, windowMs: 15 * 60 * 1000 }, |
Contributor
There was a problem hiding this comment.
Hey, why id you choose these parameters for the rate limit?
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR extends the existing rate limiting implementation by adding reusable middleware helpers and configurable rate limit tiers while maintaining backward compatibility with the current
checkRateLimit()implementation.Changes
RATE_LIMITSpresets.RateLimitTypefor standardized rate limit categories.applyRateLimit()helper for reusable rate limit enforcement.withRateLimit()wrapper for middleware-style usage.Why
While investigating Issue #912, I found an existing
rate-limit.tsimplementation already protecting several API routes. Rather than introducing a second implementation, I extended the existing helper to make it reusable across future API endpoints while preserving existing functionality.Testing
Verified the project builds until reaching the existing unrelated TypeScript error in
src/pages/admin/courses.tsx:Parameter 'course' implicitly has an 'any' type.Confirmed no additional build errors were introduced by these changes.